Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor removed_api_tests to tests against sorted strings to avoid flakiness #245

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

perdasilva
Copy link
Contributor

There seems to be some flakiness on the order of the APIs. E.g.

        removed_apis_test.go:286: 
            	Error Trace:	removed_apis_test.go:286
            	Error:      	[]string{"this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for HorizontalPodAutoscaler: ([\"memcached-operator-hpa\"]),PodDisruptionBudget: ([\"memcached-operator-policy-manager\"]),"} does not contain "this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for PodDisruptionBudget: ([\"memcached-operator-policy-manager\"]),HorizontalPodAutoscaler: ([\"memcached-operator-hpa\"]),"
            	Test:       	TestValidateDeprecatedAPIS/should_return_a_warning_if_the_k8sVersion_is_empty_and_found_removed_APIs_on_1.25

from here

Verified

This commit was signed with the committer’s verified signature.
31z4 Elisei Zanko
This reverts commit beb9613.
…flakiness

Signed-off-by: perdasilva <perdasilva@redhat.com>
@openshift-ci openshift-ci bot requested review from jmrodri and njhale June 20, 2022 09:38
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@perdasilva perdasilva added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2022
@openshift-ci openshift-ci bot merged commit cb9dc0e into operator-framework:master Jun 20, 2022
@camilamacedo86
Copy link
Contributor

/lgtm

Thank you for sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants