chore(deps): bump sarama to v1.40.0 #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the module path has changed to github.com/IBM/sarama since ownership transitioned away from Shopify
It looks like the GitHub Action doesn't have a pinned golangci-lint version, so it's pulled in the latest (golangci-lint v1.54.0) which now flags a few additional issues that it didn't previously. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
|
@basvanbeek I added a commit to fix the golangci-lint failures. They weren't introduced by my change, but were caused because the GHA doesn't have a pinned version of golangci-lint |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 66.83% 66.83%
=======================================
Files 36 36
Lines 1770 1770
=======================================
Hits 1183 1183
Misses 542 542
Partials 45 45
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @dnwe. I'll take a stab at updating some of the code to please the linters and get rid of some deprecation notices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the module path has changed to github.com/IBM/sarama since ownership transitioned away from Shopify