Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ooniprobe: Update to 3.18.0 #21557

Merged
merged 1 commit into from Jul 13, 2023
Merged

Conversation

jefferyto
Copy link
Member

@jefferyto jefferyto commented Jul 13, 2023

Maintainer: @ja-pa
Compile tested: armsr-armv7, 2023-07-09 snapshot sdk
Run tested: armsr-armv7 (qemu), 2023-07-09 snapshot

Description:
This version includes support for Go 1.20 (specifically 1.20.5).

This also:

  • Adds a workaround for musl 1.2.4 compatibility in mattn/go-sqlite3

  • Sets GO_PKG_BUILD_PKG to build the main binary (ooniprobe) only

  • Updates the package license; the project was relicensed in 3.13.0

@1715173329
Copy link
Member

GO_PKG:=github.com/ooni/probe-cli built everything, but if possible please remove unnecessary binaries from this package
for example, https://github.com/ooni/probe-cli/tree/master/internal/tutorial takes about ~85 MB in this package (uncompressed)

github.com/ooni/probe-cli/cmd/ooniprobe should be enough imo

This version includes support for Go 1.20 (specifically 1.20.5).

This also:

* Adds a workaround for musl 1.2.4 compatibility in mattn/go-sqlite3[1]

* Sets GO_PKG_BUILD_PKG to build the main binary (ooniprobe) only

* Updates the package license; the project was relicensed in 3.13.0[2]

[1]: mattn/go-sqlite3#1164
[2]: ooni/probe-cli#446

Signed-off-by: Jeffery To <jeffery.to@gmail.com>
@jefferyto
Copy link
Member Author

please remove unnecessary binaries

This is done - thanks for checking 🙏

@neheb neheb merged commit dc7382e into openwrt:master Jul 13, 2023
13 checks passed
@jefferyto jefferyto deleted the ooniprobe-3.18.0 branch July 14, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants