-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Anoncreds schemas and validation #3397
fix: Anoncreds schemas and validation #3397
Conversation
Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
1f76e66
to
074adc2
Compare
Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good! Just a couple of minor points on pluggability of DID Methods and how best to handle that.
1506078
to
190f649
Compare
Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
190f649
to
5739bcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Only thing i'm wondering about was why the examples and validation endpoints got changed for /revocation endpoints. These can still only handle indy objects? Changing them for /anoncreds/revocation endpoints definitely makes sense. |
Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
@jamshale Reverted the /revocation endpoint changes. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Not sure why I can't merge main into this branch with github. When it's up-to-date I'll merge it. |
Sorry. Just merged a fix for the coverage reporting. I won't merge anything else if you update this one more time. |
|
* fix: Anoncreds schemas and validation Signed-off-by: DaevMithran <daevmithran1999@gmail.com> * fix: Anoncreds schemas and validation Signed-off-by: DaevMithran <daevmithran1999@gmail.com> * fix tests Signed-off-by: DaevMithran <daevmithran1999@gmail.com> * Move did:cheqd wallet injection to plugins Signed-off-by: DaevMithran <daevmithran1999@gmail.com> * Revert /revocation endpoint schema to INDY Signed-off-by: DaevMithran <daevmithran1999@gmail.com> --------- Signed-off-by: DaevMithran <daevmithran1999@gmail.com>
No description provided.