Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant annotation @ResponseBody #252

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

donemin
Copy link
Contributor

@donemin donemin commented Mar 27, 2024

Description

@Responsebody on method, already defined at @RestController annotation

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sorry, something went wrong.

Signed-off-by: Dongin.min <dongin.min@navercorp.com>
@donemin
Copy link
Contributor Author

donemin commented Mar 27, 2024

@reta close #251 and reopen this.

@reta
Copy link
Collaborator

reta commented Mar 27, 2024

@reta close #251 and reopen this.

Thanks @donemin , please remove unused import:

 * What went wrong:
Execution failed for task ':spring-data-opensearch-examples:spring-boot-gradle:spotlessJavaCheck'.
> The following files had format violations:
      src/main/java/org/opensearch/data/example/rest/MarketplaceRestController.java
          @@ -13,7 +13,6 @@
           import·org.springframework.web.bind.annotation.GetMapping;
           import·org.springframework.web.bind.annotation.RequestMapping;
           import·org.springframework.web.bind.annotation.RequestParam;
          -import·org.springframework.web.bind.annotation.ResponseBody;
           import·org.springframework.web.bind.annotation.RestController;
           
           @RestController
  Run './gradlew :spring-data-opensearch-examples:spring-boot-gradle:spotlessApply' to fix these violations.

Signed-off-by: Dongin.min <dongin.min@navercorp.com>
@donemin donemin requested a review from reta March 29, 2024 07:00
@reta
Copy link
Collaborator

reta commented Mar 29, 2024

Thank you @donemin !

@reta reta merged commit 6558023 into opensearch-project:main Mar 29, 2024
10 checks passed
@donemin donemin deleted the redundant-annotation branch April 2, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants