Add refresh policy setting when creating DeleteByQueryRequest #245
+55
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bcc829 <abcdefssk1@gmail.com>
|
Looks pretty straightforward. Needs tests, please? |
|
Test code has been added. Should integration test code also be added? |
Signed-off-by: bcc829 <abcdefssk1@gmail.com>
reta
approved these changes
Mar 18, 2024
Thank you @bcc829 , I think this is fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add refresh policy setting when creating DeleteByQueryRequest
(Is the wait_for option among the refresh options of Delete by query supported? An error occurs when making an actual request. see please opensearch-project/OpenSearch#12687)
Issues Resolved
See please #244
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.