Fix serialization of KnnQuery's method_parameters property
#1427
+99
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtansia
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
force-pushed
the
fix/knn-query-method-parameters
branch
from
9fc8f6d to
f2d3f80
Compare
reta
approved these changes
Feb 12, 2025
VijayanB
approved these changes
Feb 12, 2025
|
Can we add Integration test either in this PR or follow up PR? |
Xtansia
force-pushed
the
fix/knn-query-method-parameters
branch
2 times, most recently
from
aec9166 to
d981394
Compare
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
force-pushed
the
fix/knn-query-method-parameters
branch
from
d981394 to
3cd48d7
Compare
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix serialization of
KnnQuery'smethod_parameterspropertyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.