Adopt guava-jre v32.1.2 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanvr
approved these changes
Aug 3, 2023
rpau
reviewed
Aug 3, 2023
| @@ -40,7 +40,7 @@ dependencies { | |||
| implementation("io.micrometer:micrometer-core:1.9.+") | |||
| runtimeOnly("org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.5.0") | |||
| runtimeOnly("it.unimi.dsi:fastutil:8.5.2") | |||
| runtimeOnly("com.google.guava:guava:31.1-jre") | |||
| runtimeOnly("com.google.guava:guava:32.1.2-jre") | |||
There was a problem hiding this comment.
We should test if this works with the gradle plugin. We have an issue with another guava dependency that caused an incompatibility issue. If the build works, then it is fine.
rpau
reviewed
Aug 3, 2023
|
I have:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Update Guava to https://github.com/google/guava/releases/tag/v32.1.2
What's your motivation?
https://nvd.nist.gov/vuln/detail/CVE-2023-2976 was reported and suppressed downstream in openrewrite/rewrite-maven-plugin@1600c14.
Anything in particular you'd like reviewers to focus on?
The release notes seem to indicate the earlier issue has been solved:
Would you agree with that assessment?
Any additional context
A previous attempt to upgrade as reverted in f487df7