Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always parse Maven wrapper files #677

Merged
merged 3 commits into from Dec 4, 2023
Merged

Conversation

timtebeek
Copy link
Contributor

What's changed?

Parse Maven wrapper files even if parseAdditionalResources = false.

What's your motivation?

Ensures consistent markers on Maven wrapper files, to allow UpdateMavenWrapper to access the active Maven version.

@timtebeek timtebeek self-assigned this Dec 4, 2023
@timtebeek timtebeek added the bug Something isn't working label Dec 4, 2023
@timtebeek timtebeek marked this pull request as draft December 4, 2023 18:23
@timtebeek
Copy link
Contributor Author

  • Still need to verify that this works with a local run & manifest inspection, given the ./mvn/wrapper path scanned.

@timtebeek timtebeek marked this pull request as ready for review December 4, 2023 22:17
@timtebeek
Copy link
Contributor Author

Confirmed fixed

85,"src/test/java/org/springframework/samples/petclinic/system/CrashControllerIntegrationTests.java",J.CompilationUnit,moderne-maven-plugin,2.8.0-SNAPSHOT,51a8e13eb3f780cb69bd6f09e7173d28
86,"src/test/java/org/springframework/samples/petclinic/system/CrashControllerTests.java",J.CompilationUnit,moderne-maven-plugin,2.8.0-SNAPSHOT,2bd0ec5b8e37014b59fa6f3a569bff9b
87,".mvn/wrapper/MavenWrapperDownloader.java",J.CompilationUnit,moderne-maven-plugin,2.8.0-SNAPSHOT,1184629e119bb27fd486827c03fafb58
88,".mvn/wrapper/maven-wrapper.properties",Properties.File,moderne-maven-plugin,2.8.0-SNAPSHOT,1877372435ec748fcb0352eaad6f4c53
89,".mvn/wrapper/maven-wrapper.jar",Quark,moderne-maven-plugin,2.8.0-SNAPSHOT,6058337c6ed4603858c3b72f754efa9b
90,"mvnw",PlainText,moderne-maven-plugin,2.8.0-SNAPSHOT,6dae69a928d8a969a700887b3433aac8
91,"mvnw.cmd",Quark,moderne-maven-plugin,2.8.0-SNAPSHOT,54a1cef9b1955d83b428819b0b22c07f
92,"build.gradle",G.CompilationUnit,mod-java,v0.1.1-SNAPSHOT,f4d75703eb4242df57720307e1687703
93,"settings.gradle",G.CompilationUnit,mod-java,v0.1.1-SNAPSHOT,823f538f69687eafdbfad49037ad583a
94,".devcontainer/Dockerfile",PlainText,native,1.7.0-SNAPSHOT,7d5f64912bc4bdd3d3ccec3944022c75

@timtebeek timtebeek merged commit 9285e03 into main Dec 4, 2023
1 check passed
@timtebeek timtebeek deleted the always-parse-maven-wrapper-files branch December 4, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants