Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid annotation processor warning #673

Merged
merged 5 commits into from Dec 4, 2023

Conversation

Bananeweizen
Copy link
Contributor

Java 21+ warns about active annotation processors, unless the compiler has been explicitly configured to accept them.

See https://bugs.openjdk.org/browse/JDK-8310061

What's changed?

Remove this warning from the build process, when running Maven on Java 21+:
grafik

Doesn't have any side effects on older JDKs.

Further references: https://inside.java/2023/07/29/quality-heads-up/ or https://github.com/khmarbaise/jdk21

Bananeweizen and others added 3 commits December 2, 2023 19:33
Java 21+ warns about active annotation processors, unless the compiler
has been explicitly configured to accept them.

See https://bugs.openjdk.org/browse/JDK-8310061
@timtebeek
Copy link
Contributor

Thanks for the hint, fix and helpful links! Looks like we might also need to bump the GitHub Actions Java version to get this to work.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project rewrite-maven-plugin: Fatal error compiling: error: invalid flag: -proc:full -> [Help 1]
https://github.com/openrewrite/rewrite-maven-plugin/actions/runs/7072162982/job/19250685994?pr=673#step:4:43

@timtebeek
Copy link
Contributor

Ok seems we depend on this one to get the tests going

@timtebeek timtebeek self-requested a review December 2, 2023 19:50
@timtebeek timtebeek added the enhancement New feature or request label Dec 2, 2023
@timtebeek timtebeek merged commit fc6829b into openrewrite:main Dec 4, 2023
1 check passed
@Bananeweizen Bananeweizen deleted the avoid_java_21_warning branch December 4, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants