Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds GroovyParser (#662) #663

Merged
merged 1 commit into from Nov 21, 2023
Merged

Adds GroovyParser (#662) #663

merged 1 commit into from Nov 21, 2023

Conversation

simonzn
Copy link
Contributor

@simonzn simonzn commented Nov 21, 2023 •
edited by timtebeek

Adds GroovyParser to the ResourceParser so we get source files with content for Groovy sources and Jenkinsfiles, instead of Quarks.

Fixes #662

@timtebeek timtebeek self-requested a review November 21, 2023 21:09
@timtebeek timtebeek added the enhancement New feature or request label Nov 21, 2023
timtebeek
timtebeek approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; indeed good enough for now not to add the classpath to the builder; the goal here is to parse Jenkinsfiles. Not yet to parse projects using src/main/groovy with a classpath.

@timtebeek
Copy link
Contributor

Confirmed to work for a petclinic migration as well; I'd say good to go. Thanks for the quick work!

@timtebeek timtebeek merged commit 28bd2ba into openrewrite:main Nov 21, 2023
1 check passed
@simonzn simonzn deleted the feature/add-groovy-parser branch November 22, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek timtebeek approved these changes

@knutwannheden knutwannheden Awaiting requested review from knutwannheden

Assignees

@simonzn simonzn

Labels
enhancement New feature or request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for parsing Groovy sources (incl. Jenkinsfiles)
2 participants
@simonzn @timtebeek