Add testcases to validate switch cases in SystemErrToLogging and ParameterizedLogging

[Laurens-W]

What's changed?

Add testcase to validate switch cases in SystemErrToLogging and ParameterizedLogging

What's your motivation?

• Always add closing semicolon for J.Case in JavaTemplate rewrite#4749

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

No failure to run any more, but now seeing some unexpected outcomes.

SystemErrToLoggingTest > useSlf4j() FAILED
    org.opentest4j.AssertionFailedError: [Unexpected result in "Test.java":
    diff --git a/Test.java b/Test.java
    index 0637b38..886db3b 100644
    --- a/Test.java
    +++ b/Test.java
    @@ -6,7 +6,8 @@ 
         void test() {
             try {
             } catch(Throwable t) {
    -            logger.error("Oh {} no", n, t);
    +            logger.error("Oh {} no", n);
    +            t.printStackTrace();
             }
         }
     }
    \ No newline at end of file
    ] 

[timtebeek]

@Laurens-W I've taken out the firstEnclosing instanceof J.Block || you had added to make the original tests pass again; do we need another test to assert the correct handling there based on the failure we saw above?

[Laurens-W]

@Laurens-W I've taken out the firstEnclosing instanceof J.Block || you had added to make the original tests pass again; do we need another test to assert the correct handling there based on the failure we saw above?

Looking at it again I realized Case needed something similar to the visitor present for Block, the exceptional case for Lambda is because a Lambda can either be a single Statement or fall into the Block visitor