crypto-refresh: minor fixes and updates for X25519/Ed25519 (new format)
#1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
changed the title
crypto-refresh: minor changes to X25519/Ed25519 (new format)crypto-refresh: minor fixes and updates for X25519/Ed25519 (new format)
Set to replace `enums.publicKey.eddsa`, which can still be used everywhere, but it will be dropped in v6. Deprecation notices have been added to ease transition.
Due to a bug, a shorter hash could be selected, and signing would throw as a result. This change fixes the issue by automatically picking SHA-256, if needed. The same was already done for legacy EdDSA signatures.
… some ECDSA subkeys The required hash size was determined based on the subkey algo rather than the primary key. As a result, if the subkey being certified required a shorter hash size than the ECDSA primary key, the issued signature would include a shorter digest than expected. This issue is not expected to have practical security impact, and it only affected keys with ECDSA subkeys with smaller key sizes than their ECDSA primary key (e.g. NIST p521 primary key and NIST p256 subkey).
larabr
force-pushed
the
eddsa-rename-legacy
branch
from
772f640
to
f9357f6
Compare
larabr
force-pushed
the
eddsa-rename-legacy
branch
2 times, most recently
from
022d8c9
to
5367f43
Compare
twiss
reviewed
Oct 4, 2023
twiss
approved these changes
Oct 4, 2023
This was required by legacy ECDH over curve25519, but not for the new format. Relevant spec: https://www.ietf.org/archive/id/draft-ietf-openpgp-crypto-refresh-10.html#name-curve25519legacy-ecdh-secre
As mandated by the new crypto-refresh spec. This applies to both the new and legacy EdDSA format. For the legacy signatures, it is not expected to be a breaking change, since the spec already mandated the use SHA-256 (or stronger).
Set to replace `enums.curve.ed25519` (resp. `.curve25519`), which can still be used everywhere, but it will be dropped in v6. Deprecation notices have been added to ease transition.
larabr
force-pushed
the
eddsa-rename-legacy
branch
from
5367f43
to
99ba76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
TODO: