Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CFB decryption performance in JS fallback for ciphers other than AES #1679

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix CFB decryption performance in JS fallback for ciphers other than AES #1679

merged 1 commit into from
Sep 18, 2023

Commits on Sep 12, 2023

  1. Fix CFB decryption performance in JS fallback for ciphers other than AES 

    By calling the underlying cipher decryption function for one block at a time.
Before, the entire ciphertext was passed for decryption, but only a subset of it (equal to the block size)
was actually processed in each iteration.
This resulted in a lot of extra work for e.g. Cast5 decryption, whose decryption function supported decrypting more than a block at once.

This issue affected non-AES ciphers (legacy), such as Cast5, in Node 18+ or in browser.
    @larabr
    larabr committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    abda7fa View commit details
    Browse the repository at this point in the history