Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for verifying User Attributes in verifyAllUsers #1637

Merged
merged 8 commits into from
May 15, 2023
Merged

Add support for verifying User Attributes in verifyAllUsers #1637

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f27d6ca
add userID checking on verifyAllUsers()
martgil Apr 27, 2023
9c23f31
add userAttribute to verifyAllUsers return data
martgil Apr 28, 2023
e2dd1d6
re-format code
martgil Apr 28, 2023
1609d17
re-format code
martgil Apr 28, 2023
7752385
add test case for checking user attributes
martgil Apr 30, 2023
9af9253
improve code readability and add new test case
martgil May 1, 2023
a4cf0a7
remove unexpected trailing comma
martgil May 3, 2023
ada3057
Merge remote-tracking branch 'origin/main' into issue-1636-add-user-i…
martgil May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/key/key.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,13 +690,15 @@ class Key {
await user.verifyAllCertifications(verificationKeys, date, config) :
[{ keyID: primaryKey.getKeyID(), valid: await user.verify(date, config).catch(() => false) }];

results.push(...signatures.map(
signature => ({
userID: user.userID.userID,
keyID: signature.keyID,
valid: signature.valid
}))
);
if (user.userID !== null && user.userID.userID !== null) {
martgil marked this conversation as resolved.
Show resolved Hide resolved
results.push(
...signatures.map((signature) => ({
userID: user.userID.userID,
twiss marked this conversation as resolved.
Show resolved Hide resolved
keyID: signature.keyID,
valid: signature.valid,
}))
);
}
}));
return results;
}
Expand Down