Add support for creating critical signature subpackets #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
reviewed
Feb 16, 2023
Assign most signature subpacket types a criticality based on whether failing to interpret their meaning would negatively impact security. For Notation Data subpackets, let the user indicate their criticality using the `signatureNotations[*].critical` property.
twiss
force-pushed
the
gen-critical-sig-subpackets
branch
from
44174e7
to
c8fe3ca
Compare
larabr
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign most signature subpacket types a criticality based on whether failing to interpret their meaning would negatively impact security.
For Notation Data subpackets, let the user indicate their criticality using the
signatureNotations[*].criticalproperty.