Add support for creating Notation Data subpackets when signing or encrypting messages #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows adding Notation Data signature subpackets when signing or encrypting a message.
twiss
force-pushed
the
sig-notation-creation
branch
from
8277309
to
9d933cb
Compare
twiss
changed the title
larabr
reviewed
Feb 16, 2023
twiss
force-pushed
the
sig-notation-creation
branch
from
9d933cb
to
70778bc
Compare
larabr
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
signatureNotationsoption tosign()andencrypt(), of the type[{ name: String, value: Uint8Array, humanReadable: bool }], to allow adding Notation Data subpackets when signing messages.Also, make
signaturePacket.rawNotations[*].criticala boolean instead of a number.