make sure that instrumentation files work #409
Merged
+877
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4259dfc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
requested changes
Feb 25, 2025
packages/cloudflare/src/cli/build/patches/plugins/load-instrumentation.ts
Outdated
Show resolved
Hide resolved
dario-piotrowicz
force-pushed
the
dario/171/instrumentation-fix
branch
from
c79fdf0 to
5644761
Compare
dario-piotrowicz
force-pushed
the
dario/171/instrumentation-fix
branch
from
983a9e0 to
065c772
Compare
dario-piotrowicz
force-pushed
the
dario/171/instrumentation-fix
branch
from
065c772 to
5268738
Compare
|
converted to draft as I just noticed that the patch does not work on Next 14 |
dario-piotrowicz
force-pushed
the
dario/171/instrumentation-fix
branch
from
4ee0160 to
e27cd2e
Compare
dario-piotrowicz
force-pushed
the
dario/171/instrumentation-fix
branch
from
b618c25 to
756b3b1
Compare
vicb
reviewed
Feb 25, 2025
vicb
reviewed
Feb 25, 2025
vicb
reviewed
Feb 25, 2025
vicb
reviewed
Feb 25, 2025
vicb
reviewed
Feb 25, 2025
vicb
reviewed
Feb 25, 2025
packages/cloudflare/src/cli/build/patches/plugins/load-instrumentation.spec.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Feb 25, 2025
packages/cloudflare/src/cli/build/patches/plugins/load-instrumentation.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Feb 25, 2025
packages/cloudflare/src/cli/build/patches/plugins/prepare-impl.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Feb 25, 2025
packages/cloudflare/src/cli/build/patches/plugins/instrumentation.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Feb 25, 2025
packages/cloudflare/src/cli/build/patches/plugins/instrumentation.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Feb 25, 2025
vicb
reviewed
Feb 25, 2025
packages/cloudflare/src/cli/build/patches/plugins/instrumentation.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Feb 25, 2025
packages/cloudflare/src/cli/build/patches/plugins/instrumentation.ts
Outdated
Show resolved
Hide resolved
vicb
approved these changes
Feb 25, 2025
Co-authored-by: Victor Berchet <victor@suumit.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #171