A bug fix in unsnap test #16724
Merged
A bug fix in unsnap test #16724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
requested changes
Mar 14, 2025
'unsnaps if snapped to other feature' test is supposedly testing unsnap signal when it snaps to another feature. However, the event was not made correctly so it didn't snap to any other feature. It was simply testing the same thing as 'unsnaps not snapped to anything' test.
yjwoo14
force-pushed
the
enhance_unsnap_test
branch
from
6d9547f to
e635856
Compare
|
📦 Preview the website for this branch here: https://deploy-preview-16724--ol-site.netlify.app/. |
ahocevar
approved these changes
Mar 17, 2025
|
Thanks, @yjwoo14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'unsnaps if snapped to other feature' test is supposedly testing unsnap signal when it snaps to another feature.
However, the event was not made correctly so it didn't snap to any other feature. It was simply testing the same thing as 'unsnaps not snapped to anything' test.