-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: config schema contains invalid types #2217
fix: config schema contains invalid types #2217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! LGTM.
- Please add an entry in the Changelog, under the
Unreleased
section. - Could we introduce a new step in github actions that runs this validation? For example, with https://github.com/OrRosenblatt/validate-json-action. Though i'm not sure what the
schema
input would be (follow up in JSON schema validation spf13/viper#1977). Or maybe a plain Go unit test? 🤔 Otherwise, nothing will prevent an incorrect schema from being written.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
==========================================
+ Coverage 89.63% 89.65% +0.02%
==========================================
Files 126 126
Lines 16785 16785
==========================================
+ Hits 15044 15047 +3
+ Misses 1333 1331 -2
+ Partials 408 407 -1 ☔ View full report in Codecov by Sentry. |
Head branch was pushed to by a user without write access
Description
The current
.config-schema.json
contains invalid types and fails when used in VSCode with the YAML extension, for example:The three changes in this PR are:
"type": "duration"
to"type": "string"
and"format": "duration"
"type": "bool"
to"type": "boolean"
"type": "float"
to"type": "number"
References
https://json-schema.org/understanding-json-schema/reference/type
Review Checklist
main