Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config schema contains invalid types #2217

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

renan-r-santos
Copy link
Contributor

@renan-r-santos renan-r-santos commented Jan 16, 2025

Description

The current .config-schema.json contains invalid types and fails when used in VSCode with the YAML extension, for example:

# yaml-language-server: $schema=https://raw.githubusercontent.com/openfga/openfga/refs/tags/v1.8.4/.config-schema.json

datastore:
  engine: postgres

image

The three changes in this PR are:

  1. Change "type": "duration" to "type": "string" and "format": "duration"
  2. Change "type": "bool" to "type": "boolean"
  3. Change "type": "float" to "type": "number"

References

https://json-schema.org/understanding-json-schema/reference/type

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Sorry, something went wrong.

@renan-r-santos renan-r-santos requested a review from a team as a code owner January 16, 2025 10:16
Copy link

linux-foundation-easycla bot commented Jan 16, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

miparnisari
miparnisari previously approved these changes Jan 16, 2025
Copy link
Contributor

@miparnisari miparnisari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM.

@miparnisari miparnisari enabled auto-merge (squash) January 16, 2025 21:32
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.65%. Comparing base (6d2f070) to head (018a4a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
+ Coverage   89.63%   89.65%   +0.02%     
==========================================
  Files         126      126              
  Lines       16785    16785              
==========================================
+ Hits        15044    15047       +3     
+ Misses       1333     1331       -2     
+ Partials      408      407       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
auto-merge was automatically disabled January 18, 2025 10:21

Head branch was pushed to by a user without write access

@miparnisari miparnisari enabled auto-merge (squash) January 21, 2025 02:09
@miparnisari miparnisari merged commit 135aef4 into openfga:main Jan 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants