Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support helper pod to use hostNetwork #224

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

niladrih
Copy link
Member

Pulling in @mctech's commit (PR #160) here.

Pull Request template

Why is this PR required? What issue does it fix?:

helper pod does not need a individual IP. setting hostNetwork=true can skip PodIP assignment step and accelerate helper pod creation.

What this PR does?:

provide an option: support helper pod to use hostNetwork

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Sorry, something went wrong.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.35%. Comparing base (cab53c4) to head (e142134).
Report is 12 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #224      +/-   ##
===========================================
- Coverage    37.91%   37.35%   -0.57%     
===========================================
  Files           36        1      -35     
  Lines         3373      779    -2594     
===========================================
- Hits          1279      291     -988     
+ Misses        2012      479    -1533     
+ Partials        82        9      -73     
Flag Coverage Δ
integrationtests 37.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mchtech and others added 3 commits December 10, 2024 14:53
Signed-off-by: mchtech <michu_an@126.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih niladrih merged commit 9f71dab into openebs:develop Dec 10, 2024
5 checks passed
@niladrih niladrih deleted the hostNetwork branch December 10, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants