Fix(Helm): Add pod priorityClassName to prevent race condition due to pod eviction #182
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernard Gütermann <bernard.gutermann@sekops.ch>
bernardgut
changed the title
|
@bernardgut -- thank you for this. I've included this commit in #194. Closing this PR. |
niladrih
added a commit
that referenced
this pull request
Jan 22, 2025
* Allow specifying additional labels to be applied to all helm chart resources This is added as a top-level `labels` map within the values file. If it is populated, these labels will be added to the storageclass. It is also added to the 'localpv.labels' variable, already included within every resource besides the storageclass. Signed-off-by: Andrew Lavery <laverya@umich.edu> Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> * Add pod priorityClassName Signed-off-by: Bernard Gütermann <bernard.gutermann@sekops.ch> Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> * refactor(chart): refactor implementation for adding extra labels to all chart resources Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> * refactor(chart): refactor implementation for adding priorityClassName Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> * fix(charts): use the correct slack channel link Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> * chore(changelog): add changelog entries for PRs 182 & 183 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> * ci: pin medyagh/setup-minikube runs to ubuntu-22.04 (#229) Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> --------- Signed-off-by: Andrew Lavery <laverya@umich.edu> Signed-off-by: Niladri Halder <niladri.halder26@gmail.com> Signed-off-by: Bernard Gütermann <bernard.gutermann@sekops.ch> Co-authored-by: Andrew Lavery <laverya@umich.edu> Co-authored-by: Bernard Gütermann <bernard.gutermann@sekops.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Why is this PR required? What issue does it fix?:
Allows to set
priorityClassName, e.gpod.spec.priorityClassName=system-node-critical. Prevents a race condition where pod might get evicted after the node running the pod gets in conditiondiskPressure=true. Thus preventing the pod from doing its job of cleaning up the pvcs that cause the condition.What this PR does?:
Allows to set
priorityClassNameDoes this PR require any upgrade changes?: no
If the changes in this PR are manually verified, list down the scenarios covered::
etc
Any additional information for your reviewer? :
Critical for single-node clusters
Checklist:
<type>(<scope>): <subject>