Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add AlmaLinux 8, CentOS Stream 9, and Fedora #221

Merged
merged 1 commit into from
Mar 7, 2025
Merged

CI: add AlmaLinux 8, CentOS Stream 9, and Fedora #221

merged 1 commit into from
Mar 7, 2025
+38 −0

Conversation

AkihiroSuda
Copy link
Member

Lima (http://lima-vm.io) is used to create VM of these distros.

Close #220

@AkihiroSuda AkihiroSuda marked this pull request as ready for review February 25, 2025 07:17
@AkihiroSuda AkihiroSuda mentioned this pull request Feb 25, 2025
Closed
kolyshkin
kolyshkin previously approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@kolyshkin
Copy link
Collaborator

@rhatdan @thaJeztah PTAL

@kolyshkin kolyshkin mentioned this pull request Mar 3, 2025
Merged
mrunalp
mrunalp previously approved these changes Mar 5, 2025
View reviewed changes
@AkihiroSuda AkihiroSuda dismissed stale reviews from mrunalp and kolyshkin via a69a5ea March 6, 2025 06:10
@AkihiroSuda
Copy link
Member Author

Updated PR to use https://github.com/lima-vm/lima-actions

@AkihiroSuda AkihiroSuda force-pushed the vm branch 2 times, most recently from bef3072 to 8875323 Compare March 6, 2025 07:32
kolyshkin
kolyshkin approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

kolyshkin
kolyshkin requested changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions re: caching.

@AkihiroSuda
Copy link
Member Author

Flaky test on Fedora

=== RUN   TestKeyLabel
    label_linux_test.go:202: write /proc/self/attr/keycreate: permission denied
--- FAIL: TestKeyLabel (0.00s)

@AkihiroSuda AkihiroSuda mentioned this pull request Mar 7, 2025
Closed
@AkihiroSuda
CI: add AlmaLinux 8, CentOS Stream 9, and Fedora

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
af36dd6 
Lima (http://lima-vm.io) is used to create VM of these distros.

Close issue 220

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
thaJeztah
thaJeztah approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kolyshkin
Copy link
Collaborator

Flaky test on Fedora

=== RUN   TestKeyLabel
    label_linux_test.go:202: write /proc/self/attr/keycreate: permission denied
--- FAIL: TestKeyLabel (0.00s)

I've seen this a few times locally and could not understand why. Maybe @rhatdan knows something? Should we add a retry to the code?

kolyshkin
kolyshkin approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@kolyshkin kolyshkin merged commit 6de9828 into opencontainers:main Mar 7, 2025
13 checks passed
@rhatdan
Copy link
Collaborator

rhatdan commented Mar 9, 2025

Permission denied is either SELinux or DAC. Would need to see AVC messages to determine which.

@kolyshkin kolyshkin added this to the v1.12 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah

@kolyshkin kolyshkin

@mrunalp mrunalp

@rhatdan rhatdan

@runcom runcom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Set up Cirrus CI to test on Fedora
5 participants
@AkihiroSuda @kolyshkin @rhatdan @mrunalp @thaJeztah