Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec generator support setting unified #722

Merged

Conversation

payall4u
Copy link
Contributor

From

When use cgroup v2, containerd and cri-o should set unified.

Signed-off-by: Zhiyu Li payall4u@qq.com

giuseppe
giuseppe previously approved these changes Sep 28, 2021
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kolyshkin
kolyshkin previously approved these changes Oct 27, 2021
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(nb)

@kolyshkin
Copy link
Contributor

@payall4u can you please rebase this so it can be merged?

Signed-off-by: payall4u <payall4u@qq.com>
@payall4u payall4u dismissed stale reviews from kolyshkin and giuseppe via a202491 January 8, 2022 00:56
@payall4u payall4u force-pushed the payall4u/support-to-config-unified branch from cdd7c5c to a202491 Compare January 8, 2022 00:56
@payall4u
Copy link
Contributor Author

payall4u commented Jan 8, 2022

@payall4u can you please rebase this so it can be merged?

Done

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks

@payall4u payall4u requested a review from giuseppe January 8, 2022 03:14
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 8ac076b into opencontainers:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants