Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add idmap and ridmap mount options #1222

Merged
merged 2 commits into from
Aug 25, 2023
Merged

config: add idmap and ridmap mount options #1222

merged 2 commits into from
Aug 25, 2023

Commits on Aug 22, 2023

  1. config: add idmap and ridmap mount options 

    Adding new fields for MOUNT_ATTR_IDMAP had the flaw that users
specifying these fields with older runtimes would result in the fields
being ignored and incorrect mounts being configured. In addition, there
is no text in the specification indicating whether MOUNT_ATTR_IDMAP
should be applied with AT_RECURSIVE (which matters for rbind idmapped
mounts).

In retrospect, the addition of the fields should've included new (dummy)
mount options that would cause errors on older runtimes. Unfortunately,
we have had a runtime-spec release since then so we cannot MUST these
new mount options, but we can SHOULD them.

Fixes: 9d1130d ("IDMapping field for mount point")
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    @cyphar
    cyphar committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2547bb0 View commit details
    Browse the repository at this point in the history

  2. config: add reference to mount_setattr(2) for idmapped mounts 

    The idmapped mounts sections do not make any reference to how the
mapping should be implemented. Add a reference to MOUNT_ATTR_IDMAP since
that is what runtimes are expected to use.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    @cyphar
    cyphar committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7b8eb69 View commit details
    Browse the repository at this point in the history