Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: change prestart hook spec to match reality #1169

Merged
merged 1 commit into from
Jan 24, 2023
Merged

config: change prestart hook spec to match reality #1169

merged 1 commit into from
Jan 24, 2023

Commits on Nov 2, 2022

  1. config: change prestart hook spec to match reality 

    runC originally implemented prestart hooks contrary to the spec. And it
still implements them the same way today, as it would break a lot of
projects which have come to rely on the existing behaviour. Any OCI
runtime implementations which want to be compatible with projects that
have come to rely on the existing runC behaviour must also implement
them contrary to the spec. Furthermore, the Lifecycle section of the
spec requires the existing runC behaviour for the prestart hook,
_directly contradicting the section of the spec which defines the
prestart hook in config.md!_ Given that existing implementations cannot
be changed, the spec contradicts existing implementations, and the spec
contradicts _itself_, amending the spec to align with the existing runC
behaviour is the only viable way to resolve the contradiction.

Signed-off-by: Cory Snider <csnider@mirantis.com>
    @corhere
    corhere committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    f225699 View commit details
    Browse the repository at this point in the history