runtime: move prestart hook in lifecycle section #1167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config.md specifies that "`prestart` hooks MUST be called after the `start` operation is called but before the user-specified program command is executed." However, the Lifecycle section in runtime.md contradicts this by showing that `prestart` hooks are called after the `create` operation is called and before the `start` operation. As the note in the config.md section for `createRuntime` hooks indicates, the order of operations in runtime.md#Lifecycle reflects the old runC behaviour which was contrary to the spec. Update the Lifecycle section to be congruent with the hook semantics as specified in config.md. Signed-off-by: Cory Snider <csnider@mirantis.com>
corhere
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
vbatts
as code owners
|
It was my understanding from that despite being wrong, the prestart hooks could not be fixed (both in spec and implementation), because doing so would have broken a lot of projects relying on the old behaviour, hence why they were deprecated and replaced. I think their placement in the lifecycle reflects that reality, and changing it is not really desirable. I may be misremembering things from the sheer infinite #1008, but just my 2¢. |
|
The actual behavior of runc can't be changed practically, so let's merge #1169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.md specifies that "
prestarthooks MUST be called after thestartoperation is called but before the user-specified program command is executed." However, the Lifecycle section in runtime.md contradicts this by showing thatprestarthooks are called after thecreateoperation is called and before thestartoperation. As the note in the config.md section forcreateRuntimehooks indicates, the order of operations in runtime.md#Lifecycle reflects the old runC behaviour which was contrary to the spec. Update the Lifecycle section to be congruent with the hook semantics as specified in config.md.Signed-off-by: Cory Snider csnider@mirantis.com