Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: runtime-spec v1.1.0-rc.2 #3830

Merged
merged 1 commit into from
May 10, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda added easy-to-review dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 18, 2023
@AkihiroSuda AkihiroSuda added this to the 1.2.0 milestone Apr 18, 2023
@AkihiroSuda AkihiroSuda changed the title go:mod: runtime-spec v1.1.0-rc.2 go.mod: runtime-spec v1.1.0-rc.2 Apr 18, 2023
kolyshkin

This comment was marked as outdated.

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Member Author

rebased

@AkihiroSuda
Copy link
Member Author

@thaJeztah @cyphar PTAL

Comment on lines 18 to 19
v1.1.0-rc.2 | time namespaces | TODO
v1.1.0-rc.2 | rsvd hugetlb cgroup | TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create tracking tickets for these (if there's none yet)? and link to those (after TODO)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

See https://github.com/opencontainers/runtime-spec/releases/tag/v1.1.0-rc.2
for the spec changes.

The `runc features` json is now defined in
https://github.com/opencontainers/runtime-spec/blob/v1.1.0-rc.2/specs-go/features/features.go

Replaces PR 3829

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit d782db4 into opencontainers:main May 10, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file easy-to-review go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants