Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the static binding for the new object-oriented binding design. #178

Merged
merged 4 commits into from
May 5, 2022
Merged

Prepare the static binding for the new object-oriented binding design. #178

merged 4 commits into from
May 5, 2022

Conversation

greg-dennis
Copy link
Contributor

This won't build until I push the new object-oriented binding open source. I deliberately prepared it in advance of that change.

@coveralls
Copy link

coveralls commented May 4, 2022

Pull Request Test Coverage Report for Build 2277586577

  • 17 of 52 (32.69%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.3%) to 66.592%

Changes Missing Coverage Covered Lines Changed/Added Lines %
topologies/binding/binding.go 17 52 32.69%
Totals Coverage Status
Change from base Build 2277527086: 2.3%
Covered Lines: 594
Relevant Lines: 892

💛 - Coveralls

@liulk
Copy link
Contributor

liulk commented May 5, 2022

Brandon made some adjustments to how we run staticcheck in #181. You may need to rebase to featureprofiles main to benefit.

@liulk liulk merged commit b17bebe into openconfig:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants