Reference Transferwise Environment Variable directly without Destructuring #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/GzSKvr81K4MAh79HCQecYkdNb6S5 |
|
Your Render PR Server URL is https://oc-storybook-demo-pr-6441.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c2r3o4jonmlaknooi540. |
SudharakaP
changed the title
znarf
approved these changes
Jun 7, 2021
Thanks for the review. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by the discussion here, #6418 (comment) there seems to be some problems with Webpacks environment variable de-structuring; webpack/webpack#5392.
This PR corrects that. I did some search on a cleaner approach and although the official documentation doesn't seem to mention that there's an idea on this post; https://prateeksurana.me/blog/using-environment-variables-with-webpack/#accessing-environment-variables-via-webpack which is to use a separate file for the environment variables, and refer them from that file. We can employ this approach if there's no objection. 🤔
@znarf @Betree