Disable running Firefox from Karma on Macs #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianKniephoff
force-pushed
the
disable-firefox
branch
from
74f28aa
to
2325397
Compare
|
Now also "works" for Intel Macs, thx for the hint @mtneug. |
|
Apparently, Firefox knows that I haven't used it for quite some time 🙈
|
|
Yup, I see that regularly as well xD |
JulianKniephoff
changed the title
|
Now that I look at this again: Since this is a developer-facing only change, would it make sense to retarget this to |
IMO this makes sense. Maybe change the comment, too, and remove "M1". |
|
Oh right, missed that, whoops. 🙈 |
JulianKniephoff
force-pushed
the
disable-firefox
branch
from
cdb2c95
to
12672b5
Compare
The old admin UI is on its way out anyway, so it should be fine to close opencast#3894 with this. Karma is deprecated anyway, so if we want to fix it properly, we would need to get a new (frontend) test runner in there, which I don't see happening.
I thought it worked on Intel Macs, but @mtneug tells me it doesn't. 🤷♀️
JulianKniephoff
force-pushed
the
disable-firefox
branch
from
12672b5
to
f40a1dc
Compare
mtneug
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old admin UI is on its way out anyway, so it should be fine to close #3894 with this. Karma is deprecated anyway, so if we want to fix it properly, we would need to get a new (frontend) test runner in there, which I don't see happening.
Note for reviewers: There are two commits here, which are best viewed individually. The first just fixes some formatting issues in the Karma config. Or you view the the changes with whitespace ignored, that should also hide most (not all) of those "irrelevant" changes.