Clean Install: Firefox related tests fail in admin-ui-frontend (macOS) #3894
Comments
|
Just to be sure: you do have Firefox installed, right? |
|
Yes, it is my default browser. |
|
@mliradelc you've got an M series mac right? I'm assuming you can't reproduce this? |
|
Thanks, @gregorydlogan, for ping me, I will try on my M1 On my intel based mac, I don't have issues |
|
I just tried on my M1 pro, indeed, the build fails with Firefox. I can confirm this bug, now, there are two workarounds:
Nevertheless, we need a proper fix for this bug. We removed safari tests because the plugin was very old, but with Firefox we can't have that luxury to not have it. |
|
I do have the same problem on my Mac (M1, Sonoma 14.1.2, Firefox 119.0.1). With the "disable Firefox" workaround, compiling works. But has anyone found a proper solution for this? |
|
@snoesberger @mliradelc @gregorydlogan There is a FireFoxHeadless Karma patch but Karma says it's being deprecated and not accepting new patches... Until Opencast can migrate from Karma, or Karma allows that FireFoxHeadless patch, this suggestion to omit the FireFoxHeadless test is a good workaround for running tests on Mac OS X. |
|
CC @JulianKniephoff since he was running into this today. Is there a way of getting Karma to do some logic wrt to which platforms it's testing based on their local arch? It'd be nice if Mac devs didn't have to deal with this. |
The old admin UI is on its way out anyway, so it should be fine to close opencast#3894 with this. Karma is deprecated anyway, so if we want to fix it properly, we would need to get a new (frontend) test runner in there, which I don't see happening.
|
^ Yes there is ;D |
The old admin UI is on its way out anyway, so it should be fine to close opencast#3894 with this. Karma is deprecated anyway, so if we want to fix it properly, we would need to get a new (frontend) test runner in there, which I don't see happening.
The old admin UI is on its way out anyway, so it should be fine to close opencast#3894 with this. Karma is deprecated anyway, so if we want to fix it properly, we would need to get a new (frontend) test runner in there, which I don't see happening.
The old admin UI is on its way out anyway, so it should be fine to close #3894 with this. Karma is deprecated anyway, so if we want to fix it properly, we would need to get a new (frontend) test runner in there, which I don't see happening. Note for reviewers: There are two commits here, which are best viewed individually. The first just fixes some formatting issues in the Karma config. Or you view the the changes with whitespace ignored, that should also hide most (not all) of those "irrelevant" changes.
Issue
When installing Opencast on macOS via $
mvn clean install -Pdev -DtrimStackTrace=falsea total of 41 Firefox related tests fail in the admin-ui-frontend bundle.33 of these tests seem to be related to
adminNg.services.languageIn each case there is an error reading:
See the "grepped" log file below for a description of each failed test.
To Reproduce
Steps to reproduce the behavior:
mvn clean install -PdevWorkaround
open
opencast/modules/admin-ui-frontend/test/karma.conf.jsand edit the following line (should be around line 69):const allowed = new Set(['ChromeHeadless', 'FirefoxHeadless'])to
const allowed = new Set(['ChromeHeadless'])Environment Information
Log
install-errors.log
The text was updated successfully, but these errors were encountered: