-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Azure Dall-e #439
Conversation
…lecaros/azure-dalle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and the checks for api_type
are in-line with what already exists inside this repo. Before merging, can you confirm: have you tested this manually? There aren't any tests here but not much of this code looks like it requires testing. As long as you've done one end-to-end run I'll be happy.
Thanks!
Hey, I have tested it manually. Once this is checked in we will add automation in our end to exercise it, thanks! |
hey @jhallard, I have tested again using the latest set of changes and everything still looks good, so we are ready to merge, thanks for the review! |
* This PR updates openai#337 with updates for it to work with the latest API preview --------- Co-authored-by: Christian Mürtz <t-cmurtz@microsoft.com>
* This PR updates openai#337 with updates for it to work with the latest API preview --------- Co-authored-by: Christian Mürtz <t-cmurtz@microsoft.com>
This PR updates #337 with updates for it to work with the latest API preview