Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Azure Dall-e #439

Merged
merged 22 commits into from
Jun 6, 2023
Merged

Conversation

glecaros
Copy link
Contributor

@glecaros glecaros commented May 5, 2023

This PR updates #337 with updates for it to work with the latest API preview

Copy link
Contributor

@jhallard jhallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and the checks for api_type are in-line with what already exists inside this repo. Before merging, can you confirm: have you tested this manually? There aren't any tests here but not much of this code looks like it requires testing. As long as you've done one end-to-end run I'll be happy.

Thanks!

@glecaros
Copy link
Contributor Author

glecaros commented Jun 6, 2023

Changes look good and the checks for api_type are in-line with what already exists inside this repo. Before merging, can you confirm: have you tested this manually? There aren't any tests here but not much of this code looks like it requires testing. As long as you've done one end-to-end run I'll be happy.

Thanks!

Hey, I have tested it manually. Once this is checked in we will add automation in our end to exercise it, thanks!

@glecaros
Copy link
Contributor Author

glecaros commented Jun 6, 2023

hey @jhallard, I have tested again using the latest set of changes and everything still looks good, so we are ready to merge, thanks for the review!

@jhallard jhallard merged commit 6e159bf into openai:main Jun 6, 2023
@glecaros glecaros deleted the glecaros/azure-dalle branch June 6, 2023 23:23
megamanics pushed a commit to devops-testbed/openai-python that referenced this pull request Aug 14, 2024
* This PR updates openai#337 with updates for it to work with the latest API preview

---------

Co-authored-by: Christian Mürtz <t-cmurtz@microsoft.com>
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
* This PR updates openai#337 with updates for it to work with the latest API preview

---------

Co-authored-by: Christian Mürtz <t-cmurtz@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants