Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constructors that do not explicitly take a credential parameter #175

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

joseharriaga
Copy link
Collaborator

  • Removed client constructors that do not explicitly take an API key parameter or an endpoint via an OpenAIClientOptions parameter, making it clearer how to appropriately instantiate a client.
  • Removed the endpoint parameter from all client constructors, making it clearer that an alternative endpoint must be specified via the OpenAIClientOptions parameter.
  • Removed OpenAIClient's Endpoint protected property.
  • Made OpenAIClient's constructor that takes a ClientPipeline parameter protected internal instead of just protected.
  • Renamed the User property in applicable Options classes to EndUserId, making its purpose clearer.

@joseharriaga joseharriaga merged commit 13a9c68 into main Aug 20, 2024
1 check passed
@joseharriaga joseharriaga deleted the joseharriaga/Constructors branch August 20, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants