Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current span for SDK-less context propagation #510

Merged
merged 2 commits into from Apr 6, 2021

Commits on Apr 5, 2021

  1. Use current span for SDK-less context propagation

    In the absence of an SDK the API should not record spans anymore but it
    should propagate the span context. In our case absence of an SDK means
    we're using the `NoopTracer`.
    
    There are different ways to create new spans and they provide different
    ways of specifying the parent context:
    
    - Tracer::start: uses Context::current()
    - Tracer::build: uses the context from the span builder or falls back to
      the current context. BUT it did not have the fallback in the
      NoopTracer.
    - Tracer::start_with_context: uses the specified context
    
    This changes the `SpanBuilder` to make the `parent_context` in it
    non-optional. That way the current context fallback is done on
    `SpanBuilder` creation. Tracer implementations just need to read the
    `parparent_context` from the span builder.
    frigus02 committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    cfff990 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Configuration menu
    Copy the full SHA
    21f627a View commit details
    Browse the repository at this point in the history