Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[must_use] from set_tracer_provider #501

Merged
merged 2 commits into from Mar 29, 2021
Merged

Remove #[must_use] from set_tracer_provider #501

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1ab39f
Set `set_tracer_provider` no longer returns a guard: it returns back …
Mar 29, 2021
fe37b54
Explain return type for `set_tracer_provider` in function documentation.
Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion opentelemetry/src/global/trace.rs
View file
Open in desktop
Expand Up @@ -252,8 +252,10 @@ pub fn tracer_with_version(name: &'static str, version: &'static str) -> BoxedTr

/// Sets the given [`TracerProvider`] instance as the current global provider.
///
/// It returns the [`TracerProvider`] instance that was previously mounted as global provider
/// (e.g. [`NoopTracerProvider`] if a provider had not been set before).
///
/// [`TracerProvider`]: crate::trace::TracerProvider
#[must_use]
pub fn set_tracer_provider<P, T, S>(new_provider: P) -> GlobalTracerProvider
where
S: trace::Span + Send + Sync,
Expand Down