Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleanup zipkin build error #2839

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

cijothomas
Copy link
Member

#2790 for Zipkin

@cijothomas cijothomas requested a review from a team as a code owner March 20, 2025 02:38
@cijothomas cijothomas requested a review from gruebel March 20, 2025 02:39
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.7%. Comparing base (702c61d) to head (e1f2d45).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-zipkin/src/exporter/mod.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2839   +/-   ##
=====================================
  Coverage   80.7%   80.7%           
=====================================
  Files        124     124           
  Lines      23493   23490    -3     
=====================================
  Hits       18961   18961           
+ Misses      4532    4529    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We should probably reflect on codecov's config, as we find ourselves ignoring it pretty regularly.

@cijothomas cijothomas merged commit 969bedf into open-telemetry:main Mar 20, 2025
22 of 23 checks passed
@cijothomas cijothomas deleted the cijothomas/zipkin-error branch March 20, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants