Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs and metrics to default features in api, sdk and otlp crate #1783

Merged

Conversation

cijothomas
Copy link
Member

Fixes #1709
All 3 signals are planned to reach beta in the next release. This PR is changing the default for api,sdk,otlp crates to include all three signals by default. The separate feature flags are still maintained, so if anyone wants to only pick only, it is still possible.

@cijothomas cijothomas requested a review from a team as a code owner May 19, 2024 03:56
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.1%. Comparing base (29ac005) to head (2fde1b2).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1783   +/-   ##
=====================================
  Coverage   74.1%   74.1%           
=====================================
  Files        125     125           
  Lines      19484   19484           
=====================================
+ Hits       14451   14453    +2     
+ Misses      5033    5031    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good to check if we need to add this for opentelemetry-proto too.

@cijothomas
Copy link
Member Author

Thanks. Good to check if we need to add this for opentelemetry-proto too.

I left that as it is not clear why would end users need that directly...

@cijothomas cijothomas merged commit 79189a8 into open-telemetry:main May 19, 2024
21 checks passed
@cijothomas cijothomas deleted the cijothomas/default-all-signals branch May 19, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics API] - Add metrics to default features
2 participants