Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/1489 deprecate aws id generator #1573

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion opentelemetry-sdk/CHANGELOG.md
@@ -1,7 +1,13 @@
# Changelog


## vNext


### Deprecated

- XrayIdGenerator in the opentelemetry-sdk has been deprecated and moved to version 0.10.0 of the opentelemetry-aws crate.

### Added

- [#1410](https://github.com/open-telemetry/opentelemetry-rust/pull/1410) Add experimental synchronous gauge
Expand All @@ -12,7 +18,6 @@
Performance Improvement : Creating Spans and LogRecords are now faster, by avoiding expensive cloning of `Resource` for every Span/LogRecord.

### Changed

- **Breaking**
[#1313](https://github.com/open-telemetry/opentelemetry-rust/pull/1313)
[#1350](https://github.com/open-telemetry/opentelemetry-rust/pull/1350)
Expand Down
2 changes: 2 additions & 0 deletions opentelemetry-sdk/src/lib.rs
Expand Up @@ -137,6 +137,8 @@ pub mod runtime;
#[cfg(any(feature = "testing", test))]
#[cfg_attr(docsrs, doc(cfg(any(feature = "testing", test))))]
pub mod testing;

#[allow(deprecated)]
#[cfg(feature = "trace")]
#[cfg_attr(docsrs, doc(cfg(feature = "trace")))]
pub mod trace;
Expand Down
4 changes: 4 additions & 0 deletions opentelemetry-sdk/src/trace/id_generator/aws.rs
Expand Up @@ -34,6 +34,10 @@ use std::time::{Duration, UNIX_EPOCH};
/// [xray-exporter]: https://godoc.org/github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsxrayexporter
/// [xray-trace-id]: https://docs.aws.amazon.com/xray/latest/devguide/xray-api-sendingdata.html#xray-api-traceids
#[derive(Debug, Default)]
#[deprecated(
since = "0.21.3",
note = "XrayId Generator has been migrated to the opentelemetry-aws crate"
)]
pub struct XrayIdGenerator {
sdk_default_generator: RandomIdGenerator,
}
Expand Down
8 changes: 7 additions & 1 deletion opentelemetry-sdk/src/trace/mod.rs
Expand Up @@ -19,7 +19,13 @@ mod tracer;

pub use config::{config, Config};
pub use events::SpanEvents;
pub use id_generator::{aws::XrayIdGenerator, IdGenerator, RandomIdGenerator};

#[deprecated(
since = "0.21.3",
note = "XrayId Generator has been migrated to the opentelemetry-aws crate"
)]
pub use id_generator::aws::XrayIdGenerator;
pub use id_generator::{IdGenerator, RandomIdGenerator};
pub use links::SpanLinks;
pub use provider::{Builder, TracerProvider};
pub use sampler::{Sampler, ShouldSample};
Expand Down