-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable workspace default feature #1562
Changes from 1 commit
c8c7819
3835c94
646d74c
24682a4
d630375
ce4c400
74f55f3
2fb05f8
870b50e
74e6d81
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ tokio = { workspace = true, features = ["net", "sync"], optional = true } | |
wasm-bindgen = { version = "0.2", optional = true } | ||
wasm-bindgen-futures = { version = "0.4.18", optional = true } | ||
|
||
tonic = { workspace = true, optional = true } | ||
tonic = { workspace = true, optional = true, default-features = true } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of doing this, it would be nice to enable the minimal set of features actually needed to make this compile. |
||
prost = { workspace = true, optional = true } | ||
prost-types = { workspace = true, optional = true } | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ rust-version = "1.65" | |
[dependencies] | ||
opentelemetry = { version = "0.21", path = "../opentelemetry/" } | ||
opentelemetry-http = { version = "0.10", path = "../opentelemetry-http", optional = true } | ||
async-std = { workspace = true, features = ["unstable"], optional = true } | ||
async-std = { workspace = true, default-features = true, features = ["unstable"], optional = true } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Surprising that CI still fails on this... |
||
async-trait = { workspace = true, optional = true } | ||
crossbeam-channel = { version = "0.5", optional = true } | ||
futures-channel = "0.3" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: extraneous space.