Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable workspace default feature #1562

Merged
34 changes: 17 additions & 17 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,34 +35,34 @@ resolver = "2"
debug = 1

[workspace.dependencies]
async-std = "1.10"
async-std = { version = "1.10", default-features = false }
async-trait = "0.1"
bytes = "1"
env_logger = "0.10" # env_logger requires a newer MSRV
env_logger = { version = "0.10", default-features = false } # env_logger requires a newer MSRV
futures-core = "0.3"
futures-executor = "0.3"
futures-util = "0.3"
hyper = "0.14"
http = "0.2"
isahc = "1.4"
futures-util = { version = "0.3", default-features = false }
hyper = { version = "0.14", default-features = false }
http = { version = "0.2", default-features = false }
isahc = { version = "1.4", default-features = false }
log = "0.4"
once_cell = "1.13"
ordered-float = "4.0"
pin-project-lite = "0.2"
prost = "0.12"
prost = "0.12"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extraneous space.

prost-build = "0.12"
prost-types = "0.12"
rand = "0.8"
reqwest = "0.11"
serde = "1.0"
rand = { version = "0.8", default-features = false }
reqwest = { version = "0.11", default-features = false }
serde = { version = "1.0", default-features = false }
serde_json = "1.0"
temp-env = "0.3.6"
thiserror = "1"
tonic = "0.11"
thiserror = { version = "1", default-features = false }
tonic = { version = "0.11", default-features = false }
tonic-build = "0.11"
tokio = "1"
tokio = { version = "1", default-features = false }
tokio-stream = "0.1.1"
tracing = "0.1"
tracing-core = "0.1"
tracing-subscriber = "0.3"
url = "2.2"
tracing = { version = "0.1", default-features = false }
tracing-core = { version = "0.1", default-features = false }
tracing-subscriber = { version = "0.3", default-features = false }
url = { version = "2.2", default-features = false }
2 changes: 1 addition & 1 deletion examples/tracing-grpc/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ path = "src/client.rs"

[dependencies]
opentelemetry = { path = "../../opentelemetry" }
opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["rt-tokio"]}
opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["rt-tokio"] }
opentelemetry-stdout = { path = "../../opentelemetry-stdout", features = ["trace"] }
prost = { workspace = true }
tokio = { workspace = true, features = ["full"] }
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-jaeger/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ tokio = { workspace = true, features = ["net", "sync"], optional = true }
wasm-bindgen = { version = "0.2", optional = true }
wasm-bindgen-futures = { version = "0.4.18", optional = true }

tonic = { workspace = true, optional = true }
tonic = { workspace = true, optional = true, default-features = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing this, it would be nice to enable the minimal set of features actually needed to make this compile.

prost = { workspace = true, optional = true }
prost-types = { workspace = true, optional = true }

Expand Down
4 changes: 2 additions & 2 deletions opentelemetry-proto/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ serde = { workspace = true, optional = true, features = ["serde_derive"] }
hex = { version = "0.4.3", optional = true }

[dev-dependencies]
tonic-build = { workspace = true }
prost-build = { workspace = true }
tonic-build = { workspace = true, default-features = true }
prost-build = { workspace = true, default-features = true }
tempfile = "3.3.0"
serde_json = "1.0"
2 changes: 1 addition & 1 deletion opentelemetry-sdk/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ rust-version = "1.65"
[dependencies]
opentelemetry = { version = "0.21", path = "../opentelemetry/" }
opentelemetry-http = { version = "0.10", path = "../opentelemetry-http", optional = true }
async-std = { workspace = true, features = ["unstable"], optional = true }
async-std = { workspace = true, default-features = true, features = ["unstable"], optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising that CI still fails on this...

async-trait = { workspace = true, optional = true }
crossbeam-channel = { version = "0.5", optional = true }
futures-channel = "0.3"
Expand Down