Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tonic 0.11 and prost 0.12 #1536

Merged
merged 2 commits into from Feb 16, 2024
Merged

Conversation

djc
Copy link
Contributor

@djc djc commented Feb 16, 2024

Fixes #1458, replaces #1310 and #1461.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@djc djc requested a review from a team as a code owner February 16, 2024 08:19
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c05b23d) 65.5% compared to head (ab7f1cf) 65.5%.

❗ Current head ab7f1cf differs from pull request most recent head 0608948. Consider uploading reports for the commit 0608948 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1536   +/-   ##
=====================================
  Coverage   65.5%   65.5%           
=====================================
  Files        140     140           
  Lines      19569   19569           
=====================================
  Hits       12824   12824           
  Misses      6745    6745           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc
Copy link
Contributor Author

djc commented Feb 16, 2024

This test failure in coverage seems unrelated:

---- metrics::tests::second_delta_export_does_not_give_no_attr_value_if_add_not_called stdout ----
thread 'metrics::tests::second_delta_export_does_not_give_no_attr_value_if_add_not_called' panicked at opentelemetry-sdk/src/metrics/mod.rs:674:13:
No scope metrics in latest export
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    metrics::tests::second_delta_export_does_not_give_no_attr_value_if_add_not_called

test result: FAILED. 115 passed; 1 failed; 7 ignored; 0 measured; 0 filtered out; finished in 2.01s

Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you for the bump.

@cijothomas cijothomas merged commit fe2b2d5 into open-telemetry:main Feb 16, 2024
11 of 12 checks passed
@alexheretic
Copy link

Thanks for bumping tonic! It would be great to get a new release using tonic 0.11.

@hdost
Copy link
Contributor

hdost commented Feb 24, 2024

Thanks for bumping tonic! It would be great to get a new release using tonic 0.11.

There's a pending release PR #1539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: update tonic dependency to 0.10.x
4 participants