Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to owned LoggerProvider #1455

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Change to owned LoggerProvider #1455

merged 2 commits into from
Feb 7, 2024

Commits on Feb 7, 2024

  1. Change to owned TracerProvider 

    The interface to an item shouldn't take an inner value since it's
considered inner, this also allows for further optimizations in the
future as it hides the complexity from the user.

Rational:

This removes exposing the inner which doesn't need to be provided
outside of the class. The advantage of this approach is that it's a
cleaner implementation. This also removes a weak reference upgrade from
the hotpath since we need to have a strong reference in order to access
the information.

Relates open-telemetry#1209
    @hdost
    hdost committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    bdf902b View commit details
    Browse the repository at this point in the history

  2. opentelemetry: Disable events for NoopLogger 

    NoopLogger should be using a little resources as possible ideally none.
This should help accomplish that.
    @hdost
    hdost committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    18ee088 View commit details
    Browse the repository at this point in the history