Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TraceState cannot insert new key-value pairs. #567

Merged
merged 2 commits into from Jun 9, 2021

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Jun 8, 2021

fix #566

@TommyCpp TommyCpp requested a review from a team as a code owner June 8, 2021 01:25
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #567 (a8210e6) into main (dc7d81f) will increase coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head a8210e6 differs from pull request most recent head 71762f3. Consider uploading reports for the commit 71762f3 to get more accurate results
Impacted file tree graph

@@          Coverage Diff          @@
##            main    #567   +/-   ##
=====================================
  Coverage   54.7%   54.7%           
=====================================
  Files         98      98           
  Lines       8576    8586   +10     
=====================================
+ Hits        4694    4704   +10     
  Misses      3882    3882           
Impacted Files Coverage Δ
opentelemetry/src/sdk/trace/tracer.rs 85.9% <100.0%> (ø)
opentelemetry/src/trace/span_context.rs 92.4% <100.0%> (+0.6%) ⬆️
opentelemetry/src/context.rs 92.1% <0.0%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc7d81f...71762f3. Read the comment docs.

@TommyCpp
Copy link
Contributor Author

TommyCpp commented Jun 8, 2021

@jtescher While I am working on it. I also added a new Error type for TraceStateError. Will try to eliminate other places where the returned error type are () in the future PRs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtescher jtescher merged commit a2dd6e7 into open-telemetry:main Jun 9, 2021
@TommyCpp TommyCpp deleted the issue-566 branch June 10, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't not add a new key/value pair to TraceState
2 participants