feat: ignore links with invalid context #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TommyCpp
commented
May 4, 2021
TommyCpp
commented
- Ignore links with invalid context
- Fix wrong shutdown function name in READMEs.
jtescher
reviewed
May 4, 2021
opentelemetry/src/trace/tracer.rs
Outdated
| links | ||
| .into_iter() | ||
| .filter(|l| l.span_context().is_valid()) | ||
| .collect(), |
There was a problem hiding this comment.
Maybe use Vec::retain instead of allocating a new one here?
Codecov Report
@@ Coverage Diff @@
## main #538 +/- ##
=====================================
Coverage 52.2% 52.2%
=====================================
Files 96 96
Lines 8505 8506 +1
=====================================
+ Hits 4443 4447 +4
+ Misses 4062 4059 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.