feat: ignore links with invalid context (#538)

open-telemetry · May 4, 2021 · b3623ab · b3623ab
1 parent 3a8123c
commit b3623ab
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/opentelemetry-datadog/README.md b/opentelemetry-datadog/README.md
@@ -82,7 +82,7 @@ to [`Datadog`].
          // Traced app logic here...
      });
      
-     opentelemetry::global::shut_down_provider();
+     opentelemetry::global::shutdown_tracer_provider();
 
      Ok(())
  }

diff --git a/opentelemetry-jaeger/README.md b/opentelemetry-jaeger/README.md
@@ -53,7 +53,7 @@ fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
         // Traced app logic here...
     });
 
-    global::shut_down_provider(); // sending remaining spans
+    global::shutdown_tracer_provider(); // sending remaining spans
 
     Ok(())
 }
@@ -131,7 +131,7 @@ fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
         // Traced app logic here...
     });
 
-    opentelemetry::global::shut_down_provider(); // sending remaining spans
+    opentelemetry::global::shutdown_tracer_provider(); // sending remaining spans
 
     Ok(())
 }
@@ -175,7 +175,7 @@ fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
         // Traced app logic here...
     });
 
-    global::shut_down_provider(); // sending remaining spans
+    global::shutdown_tracer_provider(); // sending remaining spans
 
     Ok(())
 }

diff --git a/opentelemetry-zipkin/README.md b/opentelemetry-zipkin/README.md
@@ -53,7 +53,7 @@ fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> {
         // Traced app logic here...
     });
 
-    global::shut_down_provider();
+    global::shutdown_tracer_provider();
 
     Ok(())
 }
@@ -153,7 +153,7 @@ fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> {
         // Traced app logic here...
     });
 
-    global::shut_down_provider();
+    global::shutdown_tracer_provider();
 
     Ok(())
 }

diff --git a/opentelemetry/src/sdk/trace/span.rs b/opentelemetry/src/sdk/trace/span.rs
@@ -523,8 +523,8 @@ mod tests {
 
         let mut link = Link::new(
             SpanContext::new(
-                TraceId::from_u128(0),
-                SpanId::from_u64(0),
+                TraceId::from_u128(12),
+                SpanId::from_u64(12),
                 0,
                 false,
                 Default::default(),

diff --git a/opentelemetry/src/trace/tracer.rs b/opentelemetry/src/trace/tracer.rs
@@ -458,7 +458,8 @@ impl SpanBuilder {
     }
 
     /// Assign links
-    pub fn with_links(self, links: Vec<Link>) -> Self {
+    pub fn with_links(self, mut links: Vec<Link>) -> Self {
+        links.retain(|l| l.span_context().is_valid());
         SpanBuilder {
             links: Some(links),
             ..self