Chore/1489 deprecate aws id generator #1573
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
======================================
Coverage ? 66.0%
======================================
Files ? 140
Lines ? 19537
Branches ? 0
======================================
Hits ? 12903
Misses ? 6634
Partials ? 0 ☔ View full report in Codecov by Sentry. |
opentelemetry-sdk/CHANGELOG.md
Outdated
| @@ -1,7 +1,13 @@ | |||
| # Changelog | |||
|
|
|||
| ## Deprecation Notice | |||
|
|
|||
| XrayIdGenerator has been migrated to the opentelemetry-aws crate starting from 0.10.0. [#33](https://github.com/open-telemetry/opentelemetry-rust-contrib/pull/33) | |||
There was a problem hiding this comment.
the message is not very clear. Could you rephrase so that it is clear that we are referrung to 0.10.0 of the aws create.
Also, this can be under a "##Removed" section.
There was a problem hiding this comment.
I guess this has been deprecated in this crate, not removed yet.
There was a problem hiding this comment.
It can however be moved inside of the version. I think this may have been inspired by my jaeger deprecation, but in this case we're only deprecating a component. Where as for jaeger we're deprecating the crate.
Could be:
# Changelog
## vNext
### Deprecated
...
There was a problem hiding this comment.
how about this?
### Deprecated
- XrayIdGenerator in the opentelemetry-sdk has been deprecated and moved to version 0.10.0 of the opentelemetry-aws crate.
Fixes #
Design discussion issue (if applicable) #
Changes
Deprecates the XrayIdGenerator in the opentelemetry core sdk.
Relates #1489
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes