fix: disable workspace default feature #1562
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
=======================================
+ Coverage 66.0% 66.8% +0.8%
=======================================
Files 140 138 -2
Lines 19537 19290 -247
=======================================
Hits 12903 12903
+ Misses 6634 6387 -247 ☔ View full report in Codecov by Sentry. |
Cargo.toml
Outdated
| log = "0.4" | ||
| once_cell = "1.13" | ||
| ordered-float = "4.0" | ||
| pin-project-lite = "0.2" | ||
| prost = "0.12" | ||
| prost = "0.12" |
opentelemetry-jaeger/Cargo.toml
Outdated
| @@ -43,7 +43,7 @@ tokio = { workspace = true, features = ["net", "sync"], optional = true } | |||
| wasm-bindgen = { version = "0.2", optional = true } | |||
| wasm-bindgen-futures = { version = "0.4.18", optional = true } | |||
|
|
|||
| tonic = { workspace = true, optional = true } | |||
| tonic = { workspace = true, optional = true, default-features = true } | |||
There was a problem hiding this comment.
Instead of doing this, it would be nice to enable the minimal set of features actually needed to make this compile.
opentelemetry-sdk/Cargo.toml
Outdated
| @@ -12,7 +12,7 @@ rust-version = "1.65" | |||
| [dependencies] | |||
| opentelemetry = { version = "0.21", path = "../opentelemetry/" } | |||
| opentelemetry-http = { version = "0.10", path = "../opentelemetry-http", optional = true } | |||
| async-std = { workspace = true, features = ["unstable"], optional = true } | |||
| async-std = { workspace = true, default-features = true, features = ["unstable"], optional = true } | |||
There was a problem hiding this comment.
Surprising that CI still fails on this...
# Conflicts: # Cargo.toml
|
Interesting I think for some reason |
- remove integration test in jaeger propagator - add cargo clippy for every create
|
This likely happens because of feature unification? When compiling all crates together, some other crate might be enabling metrics such that it works. |
Follow up on #1486 (comment)
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes