opentelemetry-otlp: Default the port correctly. #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdost
force-pushed
the
bug/1509-defaults-for-grpc-incorrect
branch
3 times, most recently
from
8aee214
to
b714b28
Compare
TommyCpp
approved these changes
Feb 18, 2024
lalitb
approved these changes
Feb 18, 2024
hdost
force-pushed
the
bug/1509-defaults-for-grpc-incorrect
branch
from
b714b28
to
4afe983
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
=======================================
+ Coverage 65.8% 66.0% +0.1%
=======================================
Files 140 140
Lines 19518 19524 +6
=======================================
+ Hits 12854 12890 +36
+ Misses 6664 6634 -30 ☔ View full report in Codecov by Sentry. |
Current behavior uses http-proto port even when there's no desire to use it. Relates open-telemetry#1509 Signed-off-by: Harold Dost <h.dost@criteo.com>
hdost
force-pushed
the
bug/1509-defaults-for-grpc-incorrect
branch
from
4afe983
to
4b478c8
Compare
|
Tests added feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior uses http-proto port even when there's no desire to use it.
Relates #1509