Skip to content

Commit

Permalink
opentelemetry-otlp: Default the port correctly.
Browse files Browse the repository at this point in the history
Current behavior uses http-proto port even when there's no desire to use
it.

Relates #1509

Signed-off-by: Harold Dost <h.dost@criteo.com>
  • Loading branch information
hdost committed Feb 18, 2024
1 parent 1be83bb commit 8aee214
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
7 changes: 6 additions & 1 deletion opentelemetry-otlp/CHANGELOG.md
Expand Up @@ -2,10 +2,15 @@

## vNext

- **Breaking** Remove support for surf HTTP client [#1537](https://github.com/open-telemetry/opentelemetry-rust/pull/1537)
### Changed
- Update to tonic 0.11 and prost 0.12 (#1536)
- Fix `tonic()` to the use correct port. [#1556](https://github.com/open-telemetry/opentelemetry-rust/pull/1556)

### Removed
- **Breaking** Remove support for surf HTTP client [#1537](https://github.com/open-telemetry/opentelemetry-rust/pull/1537)
- Remove support for grpcio transport (#1534)


## v0.14.0

### Added
Expand Down
1 change: 1 addition & 0 deletions opentelemetry-otlp/src/exporter/tonic/mod.rs
Expand Up @@ -149,6 +149,7 @@ impl Default for TonicExporterBuilder {
TonicExporterBuilder {
exporter_config: ExportConfig {
protocol: crate::Protocol::Grpc,
endpoint: default_endpoint(crate::Protocol::Grpc),

Check failure on line 152 in opentelemetry-otlp/src/exporter/tonic/mod.rs

View workflow job for this annotation

GitHub Actions / lint

cannot find function `default_endpoint` in this scope
..Default::default()
},
tonic_config,
Expand Down

0 comments on commit 8aee214

Please sign in to comment.