Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions to prepare for release v0.22 #1539

Merged
merged 3 commits into from Feb 25, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Feb 16, 2024

Hope this helps. Is the release process written down anywhere?

@djc djc requested a review from a team as a code owner February 16, 2024 17:43
@cijothomas
Copy link
Member

Hope this helps. Is the release process written down anywhere?

no. See #1326 tracking issue.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.8%. Comparing base (6422524) to head (4e45893).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1539   +/-   ##
=====================================
  Coverage   66.8%   66.8%           
=====================================
  Files        138     138           
  Lines      19290   19290           
=====================================
  Hits       12903   12903           
  Misses      6387    6387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member

We also need changelog updates as well, similar to https://github.com/open-telemetry/opentelemetry-rust/pull/1343/files

@djc
Copy link
Contributor Author

djc commented Feb 16, 2024

Added the versions to changelogs.

@jtescher
Copy link
Member

Added the @open-telemetry/rust-maintainers group as crates.io owners, so any member should have permissions to manage them now 👍

@hdost
Copy link
Contributor

hdost commented Feb 17, 2024

Perhaps we merge #1553 it's a simple change but a good quality of life one.

We'd need to rebase due to conflicts, but I think it'd be worth it.

@hdost
Copy link
Contributor

hdost commented Feb 18, 2024

Perhaps also #1556

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need 2 fixes

  1. opentelemetry-jaeger - need to indicate this will be the last release of the create
  2. opentelemetry-jaeger-propagator - use 0.1.0 as version, given this is the very first release.

Rest looks good. Though I am unsure how we decide if the new version is just minor version bump or patch version? like 0.22.0 to 0.23.0 vs 0.22.1? Maybe this is something we'll have sort out and a clear policy going forward, not blocking/delaying this release.

@TommyCpp
Copy link
Contributor

Though I am unsure how we decide if the new version is just minor version bump or patch version? like 0.22.0 to 0.23.0 vs 0.22.1

If there is a breaking change it has to be minor version bump before 1.0. Versioning was discussed here https://github.com/open-telemetry/opentelemetry-rust/blob/main/VERSIONING.md

@hdost
Copy link
Contributor

hdost commented Feb 19, 2024

Need 2 fixes

1. opentelemetry-jaeger - need to indicate this will be the last release of the create

2. opentelemetry-jaeger-propagator - use 0.1.0 as version, given this is the very first release.

While I don't disagree with us deprecating it, something that never made it back into the notes of how we'll proceed with properly deprecating.
I felt that ideally we should wait for 1.0, but that was when 1.0 seemed like it might come sooner.
However, I do think we should allow at least 2 releases I believe before outright removing it.
This one could be one which means that 0.22.0 would then be the last release.

Things to note:

  • Jaeger is still 17% of our user base.
  • Today if I go to the https://crates.io/crates/opentelemetry-jaeger there's no warning shown, which means that even if someone today went to the page they might have been surprised to find out our intentions to stop supporting.
    • There were warning notices created, but it wasn't there until after the previous release.

I have created #1560 to address this.

Related issue: #995

@cijothomas
Copy link
Member

@djc Will you be continuing this PR, resolve the conflicts, so we can do the release ?

@djc
Copy link
Contributor Author

djc commented Feb 21, 2024

I'm happy to do another pass on the PR once there is a clear set of remaining issues to address, but would prefer to hold off on doing that while some comment threads have not arrived at a resolution.

@cijothomas
Copy link
Member

I'm happy to do another pass on the PR once there is a clear set of remaining issues to address, but would prefer to hold off on doing that while some comment threads have not arrived at a resolution.

There are no open questions now. This release will follow the existing convention, and that is already followed in this PR.
Remaining issues:

  1. jaeger propagator crate - use 0.1.0 as this is the first release
  2. jaeger crate deprecation issue is resolved - just rebase from main is good enough.
  3. resolve the merge conflict.

@TommyCpp @hdost Please check if this is good, so that @djc can continue.

@TommyCpp
Copy link
Contributor

jaeger propagator crate - use 0.1.0 as this is the first release
jaeger crate deprecation issue is resolved - just rebase from main is good enough.
resolve the merge conflict.

LGTM 👍

@hdost
Copy link
Contributor

hdost commented Feb 22, 2024

Yea let's go 🚀

@djc
Copy link
Contributor Author

djc commented Feb 22, 2024

BTW, opentelemetry-appender-log does have opentelemetry logs appearing in its public API, so it does actually need a semver-incompatible release number.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hdost
Copy link
Contributor

hdost commented Feb 22, 2024

@TommyCpp if you want to do the honors of the merge and release this time ?

@TommyCpp
Copy link
Contributor

I want to get #1562 in before the release but yeah I can do a version release this weekend

@cijothomas
Copy link
Member

I want to get #1562 in before the release but yeah I can do a version release this weekend

Could we do the release at the earliest, without waiting for 1562? At this stage, we are not merging any other PRs , to avoid interfering with the release, and we don't want to keep other PRs blocked for long..

@djc
Copy link
Contributor Author

djc commented Feb 23, 2024

I want to get #1562 in before the release but yeah I can do a version release this weekend

Could we do the release at the earliest, without waiting for 1562? At this stage, we are not merging any other PRs , to avoid interfering with the release, and we don't want to keep other PRs blocked for long..

As long as we get #1562 in this weekend and also release, that doesn't seem like a lot of extra delay?

@cijothomas
Copy link
Member

I want to get #1562 in before the release but yeah I can do a version release this weekend

Could we do the release at the earliest, without waiting for 1562? At this stage, we are not merging any other PRs , to avoid interfering with the release, and we don't want to keep other PRs blocked for long..

As long as we get #1562 in this weekend and also release, that doesn't seem like a lot of extra delay?

Between today vs weekend - no diff for me.
I didn't want to as people to work on a weekend.

(for the next release onwards, we can plan and try to get release process complete in under a day)

@TommyCpp TommyCpp added the integration tests Run integration tests label Feb 25, 2024
@TommyCpp TommyCpp changed the title Bump versions to prepare for release Bump versions to prepare for release v0.22 Feb 25, 2024
@TommyCpp TommyCpp merged commit ab9415a into open-telemetry:main Feb 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants